changeset 123:98a624cacd82

Get rid of all the warnings, and arrange attributes.
author Paul Fisher <paul@pfish.zone>
date Mon, 30 Jun 2025 04:26:44 -0400
parents 9e05e44050d0
children f469b8d9ad78
files libpam-sys/src/helpers.rs src/logging.rs testharness/src/lib.rs
diffstat 3 files changed, 9 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/libpam-sys/src/helpers.rs	Mon Jun 30 04:22:39 2025 -0400
+++ b/libpam-sys/src/helpers.rs	Mon Jun 30 04:26:44 2025 -0400
@@ -455,27 +455,29 @@
         )
     }
 
+    #[cfg(debug_assertions)]
     #[test]
     #[should_panic]
-    #[cfg(debug_assertions)]
     fn test_new_wrong_size() {
         let bad_vec = vec![0; 19];
         let msg = PtrPtrVec::new(bad_vec);
         let _ = msg.as_ptr::<u64>();
     }
 
+    #[allow(deprecated)]
+    #[cfg(debug_assertions)]
     #[test]
     #[should_panic]
-    #[cfg(debug_assertions)]
     fn test_iter_xsso_wrong_size() {
         unsafe {
             _ = PtrPtrVec::<u8>::iter_over_xsso::<f64>(ptr::null(), 1);
         }
     }
 
+    #[allow(deprecated)]
+    #[cfg(debug_assertions)]
     #[test]
     #[should_panic]
-    #[cfg(debug_assertions)]
     fn test_iter_linux_wrong_size() {
         unsafe {
             _ = PtrPtrVec::<u128>::iter_over_linux::<()>(ptr::null(), 1);
@@ -512,7 +514,7 @@
         }.cloned().collect();
         assert_eq!(vec!["a", "b", "c", "D"], got);
 
-        let nums = vec![-1i8, 2, 3];
+        let nums = [-1i8, 2, 3];
         let ptr = nums.as_ptr();
         let got: Vec<u8> = unsafe { PtrPtrVec::iter_over_xsso(&ptr, 3)}.cloned().collect();
         assert_eq!(vec![255, 2, 3], got);
--- a/src/logging.rs	Mon Jun 30 04:22:39 2025 -0400
+++ b/src/logging.rs	Mon Jun 30 04:26:44 2025 -0400
@@ -179,7 +179,6 @@
 #[cfg(test)]
 mod tests {
     use super::*;
-    use regex::Regex;
     use std::cell::RefCell;
 
     #[test]
@@ -187,7 +186,7 @@
         struct Logger(RefCell<Vec<(Level, String)>>);
 
         impl Logger {
-            fn log(&self, level: Level, loc: Location<'_>, text: &str) {
+            fn log(&self, level: Level, _: Location<'_>, text: &str) {
                 self.0.borrow_mut().push((level, text.to_owned()))
             }
         }
--- a/testharness/src/lib.rs	Mon Jun 30 04:22:39 2025 -0400
+++ b/testharness/src/lib.rs	Mon Jun 30 04:26:44 2025 -0400
@@ -7,11 +7,11 @@
 struct TestHarness;
 
 impl<M: PamHandleModule> PamModule<M> for TestHarness {
-    fn authenticate(handle: &mut M, args: Vec<&CStr>, flags: Flags) -> nonstick::Result<()> {
+    fn authenticate(_handle: &mut M, _args: Vec<&CStr>, _flags: Flags) -> nonstick::Result<()> {
         Ok(())
     }
 
-    fn account_management(handle: &mut M, args: Vec<&CStr>, flags: Flags) -> nonstick::Result<()> {
+    fn account_management(_handle: &mut M, _args: Vec<&CStr>, _flags: Flags) -> nonstick::Result<()> {
         Ok(())
     }
 }